fix: return correct test result status #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Jul 17, 2024
| @@ -32,7 +32,7 @@ export const getStatus = (eventName: ValueOf<Testplane['events']>, events: Testp | |||
| } else if (eventName === events.TEST_PENDING) { | |||
| return TestStatus.SKIPPED; | |||
| } else if (eventName === events.RETRY || eventName === events.TEST_FAIL) { | |||
| return hasFailedImages(testResult.assertViewResults as ImageInfoFull[]) ? TestStatus.FAIL : TestStatus.ERROR; | |||
| return isAssertViewError(testResult.err) ? TestStatus.FAIL : TestStatus.ERROR; | |||
There was a problem hiding this comment.
Test result with errors could still has failed images
There was a problem hiding this comment.
Why you check here only assert view error and don't check diff (isImageDiffError) or no ref image (isNoRefImageError)?
There was a problem hiding this comment.
Because testResult can only have assert view error.
isImageDiffError and isNoRefImageError - are image errors, and not the result ones. So if testResult has an image with isImageDiffError or isNoRefImageError - it would have AssertViewError:
- https://github.com/gemini-testing/testplane/blob/406a2d4cc0bef646de18f2ce4eae2cd87ccb6e8a/src/browser/commands/assert-view/index.js#L60
- https://github.com/gemini-testing/testplane/blob/406a2d4cc0bef646de18f2ce4eae2cd87ccb6e8a/src/worker/runner/test-runner/index.js#L57-L58
I can, though, check for other errors, just in case
KuznetsovRoman
force-pushed
the
TESTPLANE-146.fix_status
branch
from
78c0ff9 to
4ee6fd5
Compare
DudaGod
approved these changes
Jul 19, 2024
| @@ -32,7 +32,7 @@ export const getStatus = (eventName: ValueOf<Testplane['events']>, events: Testp | |||
| } else if (eventName === events.TEST_PENDING) { | |||
| return TestStatus.SKIPPED; | |||
| } else if (eventName === events.RETRY || eventName === events.TEST_FAIL) { | |||
| return hasFailedImages(testResult.assertViewResults as ImageInfoFull[]) ? TestStatus.FAIL : TestStatus.ERROR; | |||
| return isAssertViewError(testResult.err) ? TestStatus.FAIL : TestStatus.ERROR; | |||
There was a problem hiding this comment.
Why you check here only assert view error and don't check diff (isImageDiffError) or no ref image (isNoRefImageError)?
KuznetsovRoman
force-pushed
the
TESTPLANE-146.fix_status
branch
from
4ee6fd5 to
8edc243
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-146.fix_status
branch
from
8edc243 to
5763ffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now (test has failed status, and no error message is shown, though there was an error):
After this PR (test has error status and error message is shown):
